Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support llm_config in AgentOptimizer #2299

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

skzhang1
Copy link
Collaborator

@skzhang1 skzhang1 commented Apr 5, 2024

Why are these changes needed?

AgentOptimizer with OAI_CONFIG_LIST in its constructor is forcing users to learn the LLM config utilities.
Taking llm_config as inout is more convenient for users.

Related issue number

Closes #2279

Checks

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 50.03%. Comparing base (a4c1d58) to head (911ec11).
Report is 1 commits behind head on main.

Files Patch % Lines
autogen/agentchat/contrib/agent_optimizer.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2299       +/-   ##
===========================================
+ Coverage   38.16%   50.03%   +11.87%     
===========================================
  Files          78       78               
  Lines        7861     7868        +7     
  Branches     1681     1821      +140     
===========================================
+ Hits         3000     3937      +937     
+ Misses       4611     3600     -1011     
- Partials      250      331       +81     
Flag Coverage Δ
unittest 14.20% <0.00%> (?)
unittests 49.00% <0.00%> (+10.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skzhang1 skzhang1 requested a review from ekzhu April 5, 2024 20:17
@skzhang1 skzhang1 requested a review from yiranwu0 April 10, 2024 00:06
@qingyun-wu qingyun-wu added this pull request to the merge queue Apr 11, 2024
Merged via the queue into microsoft:main with commit 9069eb9 Apr 11, 2024
60 of 72 checks passed
@DLWCMD
Copy link

DLWCMD commented Apr 11, 2024

Thanks for addressing this issue. However, where can I find information on using this revised code. I see references to llm_config and ao_config_list. Thanks.

whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* support llm_config in agentoptimizer

* fix doc

* restore seed timeout

---------

Co-authored-by: “skzhang1” <“shaokunzhang529@gmail.com”>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLEASE FIX CONFIG_LIST
8 participants